Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): remove internal <FragmentWrapper> #20607

Merged
merged 1 commit into from
May 1, 2023
Merged

fix(nuxt): remove internal <FragmentWrapper> #20607

merged 1 commit into from
May 1, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I think this component isn't really needed and we can simplify our code by removing it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu May 1, 2023 11:22
@danielroe danielroe self-assigned this May 1, 2023
@codesandbox
Copy link

codesandbox bot commented May 1, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added the 3.x label May 1, 2023
manniL
manniL approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also reduce nesting in devtools -> better DX 👏

@danielroe danielroe merged commit 2c55bb6 into main May 1, 2023
@danielroe danielroe deleted the fix/remove-fragment branch May 1, 2023 11:56
@github-actions github-actions bot mentioned this pull request May 1, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees

@danielroe danielroe

Labels
3.x bug dx 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @manniL