chore: broken linting

Author: harlan-zw

docs/pages/index.vue

@@ -81,11 +81,13 @@ const { $script } = useScript<JSConfettiApi>({
   },
 })
 onMounted(() => {
-  confettiEl.value && useEventListener(confettiEl.value, 'mouseenter', () => {
-    $script.then(({ JSConfetti }) => {
-      new JSConfetti().addConfetti({ emojis: ['🎉', '🎊'] })
+  if (confettiEl.value) {
+    useEventListener(confettiEl.value, 'mouseenter', () => {
+      $script.then(({ JSConfetti }) => {
+        new JSConfetti().addConfetti({ emojis: ['🎉', '🎊'] })
+      })
     })
-  })
+  }
 })
 
 const links = [

playground/pages/npm/js-confetti.vue

@@ -11,7 +11,7 @@ export interface JSConfettiApi {
 }
 
 declare global {
-  interface Window extends JSConfettiApi {}
+  type Window = JSConfettiApi
 }
 
 const { $script } = useScriptNpm<JSConfettiApi>({

playground/scripts/myCustomScript.ts

@@ -3,8 +3,7 @@ import type { Input } from 'valibot'
 import { useScript } from '#imports'
 import type { NuxtUseScriptOptions } from '#nuxt-scripts'
 
-export interface MyCustomScriptApi {
-}
+export type MyCustomScriptApi = Record<string, any>
 
 export const MyCustomScriptOptions = object({
   id: string(),

scripts/utils.ts

@@ -35,7 +35,7 @@ export async function generateTpcContent(input: TpcDescriptor) {
 
     chunks.push(`
     declare global {
-      interface Window extends ${input.tpcTypeAugmentation} {}
+      type Window = ${input.tpcTypeAugmentation}
     }`)
   }
 

src/devtools.ts

@@ -5,10 +5,6 @@ import { useNuxt } from '@nuxt/kit'
 import type { ModuleOptions } from './module'
 import { DEVTOOLS_UI_LOCAL_PORT, DEVTOOLS_UI_ROUTE } from './constants'
 
-export interface ServerFunctions {}
-
-export interface ClientFunctions {}
-
 export function setupDevToolsUI(options: ModuleOptions, resolve: Resolver['resolve'], nuxt: Nuxt = useNuxt()) {
   const clientPath = resolve('./client')
   const isProductionBuild = existsSync(clientPath)

src/module.ts

@@ -131,7 +131,7 @@ export default defineNuxtModule<ModuleOptions>({
     nuxt.hooks.hook('modules:done', async () => {
       const registryScripts = [...scripts]
 
-      // @ts-ignore nuxi prepare is broken to generate these types, possibly because of the runtime path
+      // @ts-expect-error nuxi prepare is broken to generate these types, possibly because of the runtime path
       await nuxt.hooks.callHook('scripts:registry', registryScripts)
       const registryScriptsWithImport = registryScripts.filter(i => !!i.import?.name) as Required<RegistryScript>[]
       addImports(registryScriptsWithImport.map((i) => {

src/runtime/components/ScriptGoogleMaps.vue

@@ -135,7 +135,9 @@ defineExpose({
 
 onMounted(() => {
   watch(ready, (v) => {
-    v && emits('ready', map)
+    if (v) {
+      emits('ready', map)
+    }
   })
   watch($script.status, () => {
     if ($script.status.value === 'error') {

src/runtime/components/ScriptVimeoPlayer.vue

@@ -188,7 +188,9 @@ onMounted(() => {
   })
 
   watch(() => props.id, (v) => {
-    v && player?.loadVideo(Number(v))
+    if (v) {
+      player?.loadVideo(Number(v))
+    }
   })
   watch($script.status, (status) => {
     if (status === 'error') {

src/runtime/composables/useScriptEventPage.ts

@@ -14,7 +14,7 @@ export function useScriptEventPage(onChange?: (payload: TrackedPage) => void) {
     return payload
 
   let lastPayload: TrackedPage = { path: '', title: '' }
-  let stopDomWatcher: () => void
+  let stopDomWatcher = () => {}
   // TODO make sure useAsyncData isn't running
   nuxt.hooks.hook('page:finish', () => {
     Promise.race([
@@ -23,18 +23,20 @@ export function useScriptEventPage(onChange?: (payload: TrackedPage) => void) {
       new Promise<void>((resolve) => {
         stopDomWatcher = head.hooks.hook('dom:rendered', () => resolve())
       }),
-    ]).finally(() => {
-      stopDomWatcher && stopDomWatcher()
-    }).then(() => {
-      payload.value = {
-        path: route.fullPath,
-        title: document.title,
-      }
-      if (lastPayload.path !== payload.value.path || lastPayload.title !== payload.value.title) {
-        onChange && onChange(payload.value)
-        lastPayload = payload.value
-      }
-    })
+    ])
+      .finally(stopDomWatcher)
+      .then(() => {
+        payload.value = {
+          path: route.fullPath,
+          title: document.title,
+        }
+        if (lastPayload.path !== payload.value.path || lastPayload.title !== payload.value.title) {
+          if (onChange) {
+            onChange(payload.value)
+          }
+          lastPayload = payload.value
+        }
+      })
   })
   return payload
 }

src/runtime/registry/clarity.ts

@@ -33,7 +33,7 @@ export interface ClarityApi {
 }
 
 declare global {
-  interface Window extends ClarityApi {}
+  type Window = ClarityApi
 }
 
 export const ClarityOptions = object({