Skip to content

Commit c607d72

Browse files
committed
fix(TPC): use proper script keys
Fixes #179
1 parent 3c88385 commit c607d72

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

scripts/generateTpcScripts.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { registry } from '../src/registry'
66
import { generateTpcContent } from './utils'
77

88
export interface TpcDescriptor {
9+
fileName: string
910
label: string
1011
tpcKey: string
1112
tpcData: Output
@@ -23,11 +24,12 @@ export interface TpcDescriptor {
2324
const scripts: Array<TpcDescriptor> = [
2425
// GTM
2526
{
27+
fileName: 'google-tag-manager',
2628
label: 'Google Tag Manager',
2729
tpcKey: 'gtm',
2830
tpcData: GoogleTagManagerData as Output,
2931
tpcTypeImport: 'GoogleTagManagerApi',
30-
key: 'google-tag-manager',
32+
key: 'googleTagManager',
3133
performanceMarkFeature: 'nuxt-third-parties-gtm',
3234
returnUse: '{ dataLayer: window.dataLayers[options.dataLayerName!], google_tag_manager: window.google_tag_manager }',
3335
returnStub: 'fn === \'dataLayer\' ? [] : void 0',
@@ -37,10 +39,11 @@ const scripts: Array<TpcDescriptor> = [
3739
},
3840
// GA
3941
{
42+
fileName: 'google-analytics',
4043
label: 'Google Analytics',
4144
tpcKey: 'gtag',
4245
tpcData: GooglaAnalyticsData as Output,
43-
key: 'google-analytics',
46+
key: 'googleAnalytics',
4447
tpcTypeImport: 'GoogleAnalyticsApi',
4548
performanceMarkFeature: 'nuxt-third-parties-ga',
4649
returnUse: '{ dataLayer: window.dataLayers[options.dataLayerName!], gtag: window.gtag }',
@@ -55,7 +58,7 @@ export async function generate() {
5558
for (const script of scripts) {
5659
script.registry = registry().find(r => r.label === script.label)
5760
const content = await generateTpcContent(script)
58-
await writeFile(resolve(`./src/runtime/registry/${script.key}.ts`), content)
61+
await writeFile(resolve(`./src/runtime/registry/${script.fileName}.ts`), content)
5962
}
6063
}
6164

src/runtime/registry/google-analytics.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export type GoogleAnalyticsInput = RegistryScriptInput<typeof GoogleAnalyticsOpt
1515

1616
export function useScriptGoogleAnalytics<T extends GoogleAnalyticsApi>(_options?: GoogleAnalyticsInput) {
1717
_options = defu(_options, { dataLayerName: 'defaultGa' })
18-
return useRegistryScript<T, typeof GoogleAnalyticsOptions>(_options?.key || 'google-analytics', options => ({
18+
return useRegistryScript<T, typeof GoogleAnalyticsOptions>(_options?.key || 'googleAnalytics', options => ({
1919
scriptInput: {
2020
src: withQuery('https://www.googletagmanager.com/gtag/js', { id: options?.id }),
2121
},

src/runtime/registry/google-tag-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export type GoogleTagManagerInput = RegistryScriptInput<typeof GoogleTagManagerO
1515

1616
export function useScriptGoogleTagManager<T extends GoogleTagManagerApi>(_options?: GoogleTagManagerInput) {
1717
_options = defu(_options, { dataLayerName: 'defaultGtm' })
18-
return useRegistryScript<T, typeof GoogleTagManagerOptions>(_options?.key || 'google-tag-manager', options => ({
18+
return useRegistryScript<T, typeof GoogleTagManagerOptions>('googleTagManager', options => ({
1919
scriptInput: {
2020
src: withQuery('https://www.googletagmanager.com/gtm.js', { id: options?.id }),
2121
},

0 commit comments

Comments
 (0)