Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add explicit vue/vue-router deps #525

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: add explicit vue/vue-router deps #525

merged 1 commit into from
Sep 29, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe self-assigned this Sep 28, 2023
pi0
pi0 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for vue. BTW is vue-router also essential?

@danielroe Volta.net
Copy link
Member Author

danielroe commented Sep 28, 2023 •
edited
Loading

Yes, when using pages integration, as it's included in optimizeDeps.include.

@danielroe danielroe merged commit 31b3681 into v3 Sep 29, 2023
@danielroe danielroe deleted the chore/explicit-router branch September 29, 2023 09:20
@TechAkayy TechAkayy mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@atinux atinux Awaiting requested review from atinux

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0