-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i18n example test to actually exercise vuei18n #673
Conversation
Hi from @nuxtjs/i18n: {{ (('hello')) }} | ||
Hi from @nuxtjs/i18n: {{ $t('hello') }} | ||
</div> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div> | |
<i18n-t scope="global" keypath="message"><template #module>@nuxtjs/i18n</template></i18n-t> | |
<div> |
The error in i18n can be fixed by importing i18n
from useNuxtApp().$i18n
. However, I couldn't find a way to fix the i18n-t
component. I tried replacing it with the Translation
component imported from vue-i18n
, but the error persists.
This suggested change will also need an addition to the i18n
messages:
"message": "Hello from {module}"
As far as I can tell the issue here is because the Without looking further (though of course I will) I'm not sure whether this is something that cc: @BobbieGoede so you're aware |
Thanks for figuring that out! Indeed, that doesn't seem like something this library should fix. @obulat I wonder if we can force Openverse (or at least the test suite) to use the CJS version? |
I opened an issue with the reproductions (using composable and |
I still plan to investigate this further. |
Any updates on the investigation of this? As it stands now this problem stops us from upgrading to the @nuxt/test-utils from nuxt-vitest that we have used before. |
This shows a minimal reproduction of the issue discussed in #585