Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aria-label to be passed for navigation components #1934

Closed
Quasarman opened this issue Jul 2, 2024 · 5 comments · May be fixed by SamandarTemirxodjayev/goshtbor#28 or SamandarTemirxodjayev/goshtbor#29
Labels
enhancement New feature or request

Comments

@Quasarman
Copy link

Description

Currently it does not seem to be possible to pass the aria-label property to navigation components like UTabs, UHorizontalNavigation, UVerticalNavigation,...
This leades to accessibility issues (running lighthouse) when only using icons for these components i.e. in a mobile navigation bar.

If the aria-label can be passed this issue would be resolved.

Additional context

No response

@Quasarman
Copy link
Author

@benjamincanac Hello, I just noticed that this is not working for UTabs since there a button is used instead of a Link component. Shall I open another issue or can we re-open this one?

Copy link
Member

@Quasarman The Tabs component does not support links, you might want to use the HorizontalNavigation component instead.

@Quasarman
Copy link
Author

Quasarman commented Oct 14, 2024

Yeah i know that, yet if I use the UTabs component with icons only i have an accessibility issue because i am unable to set an aria-label for the button elements the UTabs component renderes. Would be nice if it is possible to also set the aria-label. Or should I open another issue for this?

benjamincanac added a commit that referenced this issue Oct 14, 2024
Copy link
Member

Oh sorry I got that wrong. Here you go: 3cf19ea

@Quasarman
Copy link
Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants