Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing field in command palette type #111

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

larbish
Copy link
Contributor

@larbish larbish commented Oct 31, 2022

No description provided.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 2:57PM (UTC)

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for nuxthq-ui canceled.

Name Link
🔨 Latest commit d466611
🔍 Latest deploy log https://app.netlify.com/sites/nuxthq-ui/deploys/6362850e2c85d3000a4535b2

@smarroufin
Copy link
Contributor

Since this is a "dynamic field", should we really add it in those types?
It loses its sens if someone overrides it through props:

  groupAttribute: {
    type: String,
    default: 'label'
  },
  commandAttribute: {
    type: String,
    default: 'label'
  }

Copy link
Contributor Author

larbish commented Oct 31, 2022

I think there is more sense to force the lib users to override types if they are indeed overriding props. In my case, I'm not overriding anything and using the Group type from @nuxthq/ui throws a ts error

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather put [key: string]: any instead of hard-coding label

Copy link
Contributor Author

larbish commented Nov 2, 2022

just updated it

@benjamincanac benjamincanac merged commit 28586c3 into dev Nov 2, 2022
@benjamincanac benjamincanac deleted the feat/command-palette-types branch November 2, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants