fix(Form): invalid errors when using clear
by path
#1165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Issue #1164
β Type of change
π Description
The current implementation of the clear function would set the errors ref to the result of a filter on the errors ref. However the test was checking if the errors path was equal to the path passed to the clear function. This results in all other form errors being cleared except for the error(s) that have the specified path, which is opposite of the docs say: "Clears form errors associated with a specific path. If no path is provided, clears all form errors.".
So I just set the filters test to filter all errors that has a path not equal to the path passed in to the clear function.
Resolves #1164
π Checklist