Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Form): memory leak #1185

Merged
merged 2 commits into from
Jan 2, 2024
Merged

fix(Form): memory leak #1185

merged 2 commits into from
Jan 2, 2024

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Jan 2, 2024 •
edited by atinux
Loading

🔗 Linked issue

Resolves #1081

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes memory leak in form component by capping the maximum uid value to MAX_SAFE_INTEGER and properly destroying event listeners.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jan 2, 2024 1:34pm

@romhml romhml mentioned this pull request Jan 2, 2024
Closed
@benjamincanac
Copy link
Member

@romhml I guess we'll be able to switch to useId soon: nuxt/nuxt#23368

@benjamincanac benjamincanac changed the title fix(Form): UForm causing memory leak fix(Form): memory leak Jan 2, 2024
@benjamincanac benjamincanac merged commit ea2a24b into dev Jan 2, 2024
2 checks passed
@benjamincanac benjamincanac deleted the fix-form-memory-leak branch January 2, 2024 15:36
@romhml
Copy link
Collaborator Author

romhml commented Jan 2, 2024

@benjamincanac I also checked it while fixing this, I'll keep an eye on it and integrate after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UForm causing memory leak
2 participants
@romhml @benjamincanac