Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Accordion): match event listener types #1193

Merged
merged 1 commit into from
Jan 3, 2024
Merged

chore(Accordion): match event listener types #1193

merged 1 commit into from
Jan 3, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds type assertions for these event listeners, needed for upgrade to vue 3.4.4. Discovered in https://github.com/nuxt/ecosystem-ci/actions/runs/7395824181/job/20124645666.

I would recommend adding something to confirm that _el is in fact an HTML element rather than just asserting it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 3, 2024
@danielroe danielroe self-assigned this Jan 3, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jan 3, 2024 1:47pm

@benjamincanac benjamincanac changed the title chore: match event listener types chore(Accordion): match event listener types Jan 3, 2024
@benjamincanac benjamincanac merged commit 44d93a1 into dev Jan 3, 2024
2 checks passed
@benjamincanac benjamincanac deleted the chore/event-types branch January 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @benjamincanac