-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): hydration attribute mismatch with vue 3.4
#1199
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
This PR was just a test, I'll use |
3.4
3.4
@MuhammadM1998 I've updated the PR, do you want to take a look? |
There are still some hydration issues on the Disclosure component but we can't do anything about it yet: tailwindlabs/headlessui#2913 |
Yeah you mentioned that in another PR I think and I saw it. Seems good to me and I can help testing it locally (or testing the edge release after this gets merged) if you want |
Would be very helpful yes! π I've seen some hydration issues remaining on checkbox still. |
Sure I'll take a look at it asap |
I'm also having some issues with the |
I'll check them too when I have some time hopefully |
Sorry I was really busy this week. Its on my todo list for the weekend and I'll try my best to test it. I see you bumped headless vue which should solve more issues with the IDs right? |
@MuhammadM1998 Should be good now yes π |
3.4
3.4
Amazing work, thank you @benjamincanac for being so responsive with community reports! |
Of course! It took a bit of time but it wasn't possible to fix before Nuxt |
Does this mean we wait for the next Nuxt UI update or was there something we can do now? I don't mind waiting. |
I'm not sure when I'll make a release yet but in the meantime, you can either keep the resolutions or use the |
That's right, I had forgotten about the edge channel. I can wait for the official release. Thank you! |
π Linked issue
Fixes #1171, fixes nuxt/ui-pro#181
β Type of change
π Description
We leverage the new
useId
composable from Nuxt v3.10.0 andprovideUseId
from Headless UI v1.7.18 (tailwindlabs/headlessui#2959) to fix hydration mismatches warned since Vue v3.4.Warning
Since we leverage
useId
, you'll need to install Nuxt v3.10.0.π Checklist