fix(SelectMenu): filteredOptions
might be undefined
#1541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #1540
β Type of change
π Description
In the
SelectMenu.vue
file, there's this snippet where it checks forfilteredOptions.length
But because
filteredOptions
is acomputedAsync
, there's a possibility that the object itself is still undefined, thus checking for.length
will not be possible.To solve this issue we can check whether
filteredOptions
is undefined or not by using optional chaining.π Checklist