Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Divider): add w-full only on horizontal wrapper #1565

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

shahabbasian
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The existence of the w-full class in the wrapper base causes the divider to create extra spaces in vertical mode and in flex

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

By looking at the preview, this breaks all horizontal dividers: https://ui-414u5pxnx-nuxt-js.vercel.app/dev/components/divider

@shahabbasian
Copy link
Contributor Author

By looking at the preview, this breaks all horizontal dividers: https://ui-414u5pxnx-nuxt-js.vercel.app/dev/components/divider

you're right
I added w-full to the horizontal wrapper
It seems to be working now and the problem I saw in my project has been fixed

@benjamincanac benjamincanac changed the title remove w-full class in wrapper base fix(Divider): w-full on horizontal wrapper only Mar 27, 2024
@benjamincanac benjamincanac changed the title fix(Divider): w-full on horizontal wrapper only fix(Divider): add w-full only on horizontal wrapper Mar 27, 2024
@benjamincanac benjamincanac merged commit bd8b737 into nuxt:dev Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants