feat(module): HMR support with @nuxtjs/tailwindcss
#1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineshbose
commented
Apr 14, 2024
src/module.ts
Outdated
| } | ||
| } | ||
| }) | ||
| await installModule('@nuxtjs/color-mode') |
There was a problem hiding this comment.
There was a problem hiding this comment.
I have reverted this for now as I see that a few styles are written for .dark selector (and some devs may have also done it), so we can do this later separately and ship for v3. (#1289, /cc @benjamincanac)
|
benjamincanac
changed the title
|
@ineshbose Would you know where this |
|
benjamincanac
changed the title
benjamincanac
changed the title
benjamincanac
changed the title
@nuxtjs/tailwindcss
| config: { darkMode: 'class' }, | ||
| configPath: [ | ||
| configTemplate.dst, | ||
| join(nuxt.options.rootDir, 'tailwind.config') |
There was a problem hiding this comment.
@ineshbose Are you sure this join is valid? Shouldn't it be at least tailwind.config.ts?
There was a problem hiding this comment.
Yes, it should be fine and resolved here - https://github.com/nuxt-modules/tailwindcss/blob/main/src/resolvers.ts#L17
Any issues being faced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt-modules/tailwindcss#682
Resolves #1685
Original PR: #1272
❓ Type of change
📚 Description
Will work with
@nuxtjs/tailwindcss@nightlythat is planned to release as 6.12.0 next week (not with 6.11.x due to race conditions and requirement of runningpreparebeforehand).This should no longer be a breaking change. If we continue using inline-config with 6.12.0, the module will still work but developers won't be able to take advantage of instant HMR.