Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Carousel): arrows & indicators are broken in RTL #2251

Merged
merged 7 commits into from
Oct 2, 2024
Merged

fix(Carousel): arrows & indicators are broken in RTL #2251

merged 7 commits into from
Oct 2, 2024

Conversation

Malik-Jouda
Copy link
Contributor

@Malik-Jouda Malik-Jouda commented Sep 25, 2024 •
edited
Loading

🔗 Linked issue

Resolves #1354

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before:
Screenshot 2024-09-26 at 11 11 53 AM
After:
Screenshot 2024-09-26 at 11 13 44 AM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

Is there no way to handle this with the dir="rtl" on the <html> attribute like other components? This would be the only component having a dir prop.

@Malik-Jouda
Copy link
Contributor Author

Is there no way to handle this with the dir="rtl" on the <html> attribute like other components? This would be the only component having a dir prop.

dir prop allows for automatic adjustments when switching between languages with different directions.

@benjamincanac benjamincanac merged commit db5e5c4 into nuxt:dev Oct 2, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

patrick-hofmann pushed a commit to patrick-hofmann/nuxt-ui that referenced this pull request Oct 3, 2024
@Malik-Jouda @patrick-hofmann
fix(Carousel): arrows & indicators are broken in RTL (nuxt#2251)
dcb1c2a
@Malik-Jouda Malik-Jouda deleted the fix/carousel-in-rtl branch October 8, 2024 20:58
@numselli numselli mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel arrows & indicators are broken in RTL
2 participants
@Malik-Jouda @benjamincanac