Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectMenu): allows to customize labels #2266

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

edersoares
Copy link
Contributor

@edersoares edersoares commented Sep 26, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Avoids to use slots or props to customize labels in SelectMenu.

@benjamincanac
Copy link
Member

Would you mind doing the same for InputMenu? This can be done in the same PR. I'd rather keep both components 1:1.

@edersoares
Copy link
Contributor Author

@benjamincanac done in #2295

@benjamincanac benjamincanac merged commit 54e713d into nuxt:dev Oct 31, 2024
1 check passed
@edersoares edersoares deleted the select-menu-label branch October 31, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants