feat(Avatar): handle chipText
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
✅ Live Preview ready!
|
✅ Live Preview ready!
|
|
@jaybharadia is attempting to deploy a commit to the Nuxt Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
I think Live Preview is not showing the actual update i did. Component not properly loaded in live preview. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Approved the Vercel deployment so we can properly see the changes applied from Vue code. |
benjamincanac
requested changes
Jun 19, 2023
|
|
is this PR ready to merge ? or any additional updates needed |
benjamincanac
force-pushed
the
dev
branch
2 times, most recently
from
3b81bea
to
4863636
Compare
benjamincanac
approved these changes
Jun 22, 2023
|
I've made some changes to your PR to match the overall design of the library. Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #286
Please NOTE
Latest updates from
devbranchchipVarianthas been removed and replaced with background property inapp.config.tsHere are the screenshots for updated
Avatar.vuechipText support.Updated Documentation