Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve RTL support #334

Merged
merged 12 commits into from
Jun 23, 2023
Merged

Conversation

Haythamasalama
Copy link
Contributor

@Haythamasalama Haythamasalama commented Jun 22, 2023

#332

I plan to include getting-started#features as a reference in the documentation.

 Support for both LTR (left-to-right) and RTL (right-to-left) languages.

Additionally, I intend to provide examples on the examples page for RTL and LTR usage, similar to :

https://tailwindcss.com/blog/tailwindcss-v3-3#simplified-rtl-support-with-logical-properties.

@benjamincanac
Let me know what you think ?

@vercel
Copy link

vercel bot commented Jun 22, 2023

@Haythamasalama is attempting to deploy a commit to the Nuxt Labs Team on Vercel.

A member of the Team first needs to authorize it.

@benjamincanac benjamincanac mentioned this pull request Jun 22, 2023
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of supporting RTL in the docs components?

@Haythamasalama
Copy link
Contributor Author

What's the point of supporting RTL in the docs components?

I think for everyone who needs to copy examples in documents like pagination, it's good to copy them with support for LTR and RTL?

@Haythamasalama Haythamasalama marked this pull request as draft June 22, 2023 17:29
@Haythamasalama
Copy link
Contributor Author

Haythamasalama commented Jun 22, 2023

@benjamincanac
@HassanKadhim

I found some issues in other components after digging deeper into them related to right-0 and left-0 that need to be worked on.

@nuxt-studio
Copy link

nuxt-studio bot commented Jun 22, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview 3769947

@Haythamasalama
Copy link
Contributor Author

@benjamincanac

I made a review for All components with examples in the documents, and I think now all should be supported for RTL.

✨ Componets That Have Iuess :

  • Avatar Group

image

image

  • Input - (trailing)

image

image

  • Select Menu

image

image

  • Toggle

image

image

  • Command Palette

image
image

image
image

  • Vertical Navigation

image

image

  • Pagination - (Icons for prev / next)

image

image

  • Notifications
  • position

@Haythamasalama Haythamasalama marked this pull request as ready for review June 22, 2023 19:15
@HassanKadhim
Copy link
Contributor

@benjamincanac Has this been reviewed?

@benjamincanac benjamincanac changed the title feat: support RTL chore: improve RTL support Jun 23, 2023
@benjamincanac
Copy link
Member

Do you still have things you want to add or can I merge it? 😊

@Haythamasalama
Copy link
Contributor Author

Haythamasalama commented Jun 23, 2023

Do you still have things you want to add or can I merge it? 😊

I reviewed all components with examples in the documents, and it should work fine with RLT and LTR. ✅

@benjamincanac benjamincanac merged commit 278a1ea into nuxt:dev Jun 23, 2023
@benjamincanac
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants