-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve RTL support #334
Conversation
@Haythamasalama is attempting to deploy a commit to the Nuxt Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of supporting RTL in the docs components?
I think for everyone who needs to copy examples in documents like pagination, it's good to copy them with support for LTR and RTL? |
I found some issues in other components after digging deeper into them related to |
✅ Live Preview ready!
|
I made a review for All components with examples in the documents, and I think now all should be supported for RTL. ✨ Componets That Have Iuess :
❌ ✅
✅
❌ ✅
❌ ✅
❌ ✅
❌ ✅
❌ ✅
|
@benjamincanac Has this been reviewed? |
Do you still have things you want to add or can I merge it? 😊 |
I reviewed all components with examples in the documents, and it should work fine with RLT and LTR. ✅ |
Thanks :) |
#332
I plan to include
getting-started#features
as a reference in the documentation.Additionally, I intend to provide examples on the examples page for
RTL and LTR
usage, similar to :https://tailwindcss.com/blog/tailwindcss-v3-3#simplified-rtl-support-with-logical-properties.
@benjamincanac
Let me know what you think ?