Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add removeableSort prop to table to allow removing of all sorting #335

Closed
wants to merge 2 commits into from

Conversation

TomSmith27
Copy link
Contributor

@TomSmith27 TomSmith27 commented Jun 22, 2023

fixes #300

@vercel
Copy link

vercel bot commented Jun 22, 2023

Someone is attempting to deploy a commit to the Nuxt Labs Team on Vercel.

A member of the Team first needs to authorize it.

@nuxt-studio
Copy link

nuxt-studio bot commented Jun 22, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview a5b3de7

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not just do this behaviour by default unless it's the attribute specified in the sort prop?

Also, there is a lot of formatting diff in your PR, could you revert them?

@TomSmith27
Copy link
Contributor Author

Can we not just do this behaviour by default unless it's the attribute specified in the sort prop?

Do you mean always have the ability to unsort a column? Im not sure what the attribute in the sort prop would be?

Also, there is a lot of formatting diff in your PR, could you revert them?

Ah ye i was getting errors if i didn't format it such as this
image

And i think the build showed the same errors? Do you use VSCode with format on save or?

@benjamincanac
Copy link
Member

The sort attribute allows to define a default sort. Yes we could always say for non-default columns that the third click unselects it I guess.

@benjamincanac
Copy link
Member

Sorry but there were way too many changes in your PR to be reviewable. Closing in favor of 1ff11ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a default option to sorting table columns
2 participants