Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): new component #450

Merged
merged 6 commits into from
Jul 27, 2023
Merged

feat(Tabs): new component #450

merged 6 commits into from
Jul 27, 2023

Conversation

benjamincanac
Copy link
Member

Resolves #162

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jul 27, 2023 1:47pm

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 27, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview d5c0259

@oritwoen
Copy link
Contributor

Thanks for you work @benjamincanac :)

I was thinking about an additional mode that could be added. Where Buttons for Tabs have the to parameter as a link. If such a parameter is set, the panel is disabled and the button becomes active if the URL is equal to the to parameter.

A nice addition for navigating between pages in more complex projects. E.g. routing in Nuxt.

Copy link
Member Author

At start I wanted tabs that could handle slots or links at the same time but is there really a use-case where you have both mixed at the same time?

For links you can use the UVerticalNavigation with just a flex class on it.

@oritwoen
Copy link
Contributor

Yes, it can be done the way you are talking about. So basically let tabs be tabs and navigation be navigation. I thought it would be a nice addition without much customization of the appearance, but you're right that the scopes of the component can be mixed up too much.

So let's forget about the topic ;)

@benjamincanac benjamincanac merged commit 8298b62 into dev Jul 27, 2023
1 check passed
@benjamincanac benjamincanac deleted the pr/162 branch July 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Tabs
2 participants