Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ComponentExample): automatically read code #789

Merged
merged 9 commits into from
Oct 9, 2023

Conversation

KeJunMao
Copy link
Contributor

@KeJunMao KeJunMao commented Oct 7, 2023

πŸ”— Linked issue

link #733

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Oct 9, 2023 8:45am

@MuhammadM1998
Copy link
Contributor

Thanks a lot I've been struggling with this while trying to learn about the codebase. One note is the button still shows only the padded prop and misses the icon="i-heroicons-x-mark-20-solid" as written in the source code. The button content file isn't changed in this PR so maybe you plan to update it later. Thanks again πŸ™
Screenshot 2023-10-07 124520

@KeJunMao
Copy link
Contributor Author

KeJunMao commented Oct 7, 2023

Hi @MuhammadM1998 , The button component uses content/ComponentCard.vue, and this PR only supports content/ComponentExample.vue

@MuhammadM1998
Copy link
Contributor

Yes I saw that when I looked at the code and thought you'll refactor it too to use ComponentExample, maybe ask benjamin if this is a good idea?

@KeJunMao
Copy link
Contributor Author

KeJunMao commented Oct 7, 2023

Let's wait for benjamin's suggestion for this PR first. πŸ˜€

}
// // overwrite default source AKA `content` directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment this?

Copy link
Contributor Author

@KeJunMao KeJunMao Oct 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

China sometimes blocks github, so i disabled github driver in local develop,I apologize that forgot to clean up it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 😊

@benjamincanac
Copy link
Member

Truly awesome PR, this will remove so much markdown code and make it so much easier to maintain, thanks a lot! 😊

I think we can merge this first and then solve the ComponentCard issue.

It was intentional to hide some props or tailwind classes to have clean examples at first but I guess it can be quite annoying when copy-pasting the code-blocks indeed.

@benjamincanac benjamincanac changed the title docs(componentExample): automatically read code docs(ComponentExample): automatically read code Oct 7, 2023
@benjamincanac
Copy link
Member

Did you exclude some :component-example refactor on purpose? I still some with the old behaviour in table.md and command-palette.md.

@benjamincanac benjamincanac merged commit fe348b4 into nuxt:dev Oct 9, 2023
1 of 2 checks passed
@benjamincanac
Copy link
Member

Thanks a lot! 😊

@benjamincanac
Copy link
Member

@KeJunMao Do you plan to work on the ComponentCard now? My guess for this is we just need to remove the baseProps and put everything into props to solve #733, right?

@KeJunMao
Copy link
Contributor Author

KeJunMao commented Oct 9, 2023

let me do it!

@KeJunMao KeJunMao deleted the feat/docs branch October 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants