feat(Meter): new component #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Asking for review to @benjamincanac mostly because Vercel doesn't want to deploy and I can't see how to fix (at least the CI passes) |
DarkGhostHunter
force-pushed
the
feat/meter
branch
from
3f7a234
to
2ea1daa
Compare
|
Welp, I give up until I can see the errors and make the proper fixes. |
|
Found the culprit, it was a link pointing to the #697 |
|
@DarkGhostHunter I've updated the PR a bit, I just have a weird visual on the MeterGroup with the rounded: |
benjamincanac
approved these changes
Oct 27, 2023
|
@DarkGhostHunter I've made all the changes I wanted, I'll wait for you to review before I merge! |
I'm AFK but I don't see anything weird on the changes, apart from some new code to keep it up to date. |
|
Its fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Rework of #708. It's like #697 but different semantics.
❓ Type of change
📚 Description
It creates a
<meter>tag and supercharges it with reactive elements. It follows the same principles of #697:minandmaxvalues.📝 Checklist
🗒️ Notes
As with the
<progress>element, I decided to use the<meter>element for semantic reasons, instead of just shoving<div>and call it a day. This also means it uses targeted CSS selectors for WebKit/Blink and Gecko/Quantum, which adds some development overhead for the sake of consistency.