Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: don't add pro path if it doesn't exist #917

Merged
merged 3 commits into from
Nov 3, 2023
Merged

docs: don't add pro path if it doesn't exist #917

merged 3 commits into from
Nov 3, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 3, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is causing nuxt/ecosystem-ci to fail: see https://github.com/nuxt/ecosystem-ci/actions/runs/6741450354/job/18335361004.

🚨 Actually, even with this fix it will still fail as /pro gives a 404 - page not found. So it may not be the right fix here.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working documentation Improvements or additions to documentation labels Nov 3, 2023
@danielroe danielroe self-assigned this Nov 3, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 3, 2023 1:33pm

@benjamincanac benjamincanac merged commit c73a2ab into dev Nov 3, 2023
2 checks passed
@benjamincanac benjamincanac deleted the fix/nonexistent-pro branch November 3, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @benjamincanac