-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Carousel): new component #927
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@benjamincanac what do you thing about this? |
I hope this will be merged soon. |
Still thinking about this but I'm not sure there is a point to include this in |
Hi @benjamincanac! Very interesting topic. I will give my very personal opinion on this. For me, one of the main advantage of installing a UI Library is to have the maximum of built in UI components in it. Besides, it adds on "paradox of choices". I don't want to spend time searching and comparing external libraries when I just want to add a basic carousel to my project on a single page. It just not worths it. While I can absolutely understand the point for charts because it's very specific and requires a huge work on itself, it's less obvious for carousel which is handled by most of UI libraries. In the end, I hate my project being a patchwork of small singled-purpose libraries. The more I have this "all-batteries-included" feeling, the more I feel confident. And I have the very subjective feeling that people using Nuxt (and Nuxt UI) prefer ease over the rest. A good philosophy could be to propose simple Nuxt UI carousel for basic users and tell to power users: "if you need a more advanced carousel, take a look to library X". |
I agree with you, a Carousel might not be as complex as charts or datepickers! What about this #1027 then? I'm not entirely sure where to draw the line on what should be or not included in the library.. I'm currently focused on other topics but I'll try to review this asap! |
#1027 looks like the same than Carousel but dedicated to images. Not sure it deserves a whole component for it.
I understand... IMO having a built-in carousel more or less the same than this one in Nuxt UI would still be great as it would give the choice to users:
|
Sounds good to me! π |
I've been away for a while and there's so much going on here ;) In my opinion, we should provide the basic elements of the user interface (as the name of the package suggests ;p) and it seems to me that the carousel is such an element - just like a table or forms (for them there are also dedicated more advanced solutions - FormKit, vue-good-table etc) If someone will need a more advanced solution then they will consciously choose it or customize/expand this basic one (depending on actual needs) So the question @benjamincanac - should I update this request and we will want to use it or do we let it go for now? If we want to use it, are there any comments/suggestions on the code itself or how it works? |
I haven't reviewed it in detail yet but you can fix the conflict on the |
Ok, I'll try to figure it out tonight or tomorrow night |
That's done for you. (currently going over PRs affected by the |
@Gobler Would you mind adding the |
@Gobler I've made a few changes to your PR if you want to take a look! |
π Linked issue
#550
β Type of change
π Description
Add new full customizable carousel component for resolves #550
Features:
π¨ Preview
π Checklist