Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Runtime Query + CPP Checks #113

Merged
104 commits merged into from
Jul 29, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Jul 4, 2022

Enables internal members to query the runtime resources from a static thread_local member of the resources::Manager

This builds on #112

This diff will highlight what's in this PR:
pull-request/112...pull-request/113

Appended to this PR is a repo wide update to correct all cpp_checks that are now failing.

Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Once #112 goes in.

src/internal/resources/manager.cpp Show resolved Hide resolved
src/internal/resources/manager.cpp Show resolved Hide resolved
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanolson ryanolson requested a review from a team as a code owner July 29, 2022 03:23
@ryanolson ryanolson changed the title Internal Runtime Query Internal Runtime Query + CPP Checks Jul 29, 2022
@ryanolson
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit b6744a9 into nv-morpheus:branch-22.08 Jul 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants