Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function wrappers with functools.partial #277

Merged
8 commits merged into from
Jan 27, 2023

Conversation

mdemoret-nv
Copy link
Contributor

If you used functools.partial with any operator function, it would incorrectly thing you wanted to unpack tuples into arguments. This improves on the function signature handling to support using partial functions.

Also includes fixes to the conda build.

@mdemoret-nv mdemoret-nv requested review from a team as code owners January 27, 2023 18:33
@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 27, 2023
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all tests are passing.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #277 (fcb18ca) into branch-23.01 (c9d8aaf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #277      +/-   ##
================================================
+ Coverage         72.90%   72.92%   +0.02%     
================================================
  Files               381      381              
  Lines             13097    13103       +6     
  Branches            989      991       +2     
================================================
+ Hits               9549     9556       +7     
+ Misses             3548     3547       -1     
Flag Coverage Δ
cpp 68.72% <0.00%> (-0.02%) ⬇️
py 40.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/mrc/_pymrc/src/utilities/function_wrappers.cpp 79.16% <100.00%> (+1.89%) ⬆️
cpp/mrc/src/public/coroutines/thread_pool.cpp 92.30% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d8aaf...fcb18ca. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@ghost ghost merged commit f1a1132 into nv-morpheus:branch-23.01 Jan 27, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_fix-function-wrappers branch January 27, 2023 21:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants