Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to only add fcoroutines flag if clang version is less than 16 + bump to latest utils #288

Merged
2 commits merged into from
Feb 8, 2023

Conversation

drobison00
Copy link
Contributor

Clang will complain about deprecated flags if you pass fcoroutines to 16 or higher; this handles both cases and avoids warning spam.

@drobison00 drobison00 added non-breaking Non-breaking change enhancement Additional functionality added to an existing feature labels Feb 8, 2023
@drobison00 drobison00 requested a review from a team as a code owner February 8, 2023 22:11
@drobison00 drobison00 self-assigned this Feb 8, 2023
@drobison00 drobison00 added the improvement Improvement to existing functionality label Feb 8, 2023
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

@dagardner-nv dagardner-nv self-requested a review February 8, 2023 22:21
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #288 (b13048c) into branch-23.03 (32301e9) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.03     #288      +/-   ##
================================================
- Coverage         72.98%   72.95%   -0.04%     
================================================
  Files               381      381              
  Lines             13117    13117              
  Branches            993      993              
================================================
- Hits               9573     9569       -4     
- Misses             3544     3548       +4     
Flag Coverage Δ
cpp 68.70% <ø> (-0.04%) ⬇️
py 41.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/memory/host_resources.cpp 68.57% <0.00%> (-5.72%) ⬇️
cpp/mrc/src/internal/resources/manager.cpp 90.90% <0.00%> (-1.02%) ⬇️
cpp/mrc/src/internal/system/partitions.cpp 78.19% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32301e9...b13048c. Read the comment docs.

@drobison00
Copy link
Contributor Author

/merge

@ghost ghost merged commit e170431 into nv-morpheus:branch-23.03 Feb 8, 2023
@drobison00 drobison00 deleted the devin_clang_cmake_fix branch February 8, 2023 22:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants