Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling on pipeline::Controller updates #29

Merged
1 commit merged into from
Jun 14, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Jun 14, 2022

Fixes #26 by improving error handling on the pipeline::Controller update method

@ryanolson ryanolson added bug Something isn't working non-breaking Non-breaking change labels Jun 14, 2022
@ryanolson ryanolson requested a review from a team as a code owner June 14, 2022 04:51
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mdemoret-nv mdemoret-nv changed the base branch from main to branch-22.06 June 14, 2022 22:46
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 2b407ba into nv-morpheus:branch-22.06 Jun 14, 2022
@ryanolson ryanolson deleted the error_on_controller branch June 14, 2022 23:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Segment hangs if an error occurs in segment initializer.
3 participants