Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ObservableProxy::pipe to support any number of operators #387

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

cwharris
Copy link
Contributor

Description

Adds support for unlimited pipe arguments.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Sep 18, 2023
@cwharris cwharris requested a review from a team as a code owner September 18, 2023 14:16
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cwharris
Copy link
Contributor Author

/ok to test

@cwharris
Copy link
Contributor Author

/ok to test

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #387 (1702de9) into branch-23.11 (40d20a3) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head 1702de9 differs from pull request most recent head bce621b. Consider uploading reports for the commit bce621b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #387      +/-   ##
================================================
+ Coverage         73.35%   73.38%   +0.02%     
================================================
  Files               385      382       -3     
  Lines             13663    13354     -309     
  Branches           1025     1012      -13     
================================================
- Hits              10023     9800     -223     
+ Misses             3640     3554      -86     
Flag Coverage Δ
cpp 69.35% <0.00%> (-0.06%) ⬇️
py 42.22% <83.33%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/mrc/_pymrc/src/subscriber.cpp 24.52% <83.33%> (+7.86%) ⬆️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d20a3...bce621b. Read the comment docs.

@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5a4a1a4 into nv-morpheus:branch-23.11 Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants