Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Register add-on in translation system]: TeleNVDA #89

Closed
1 task done
nvdaes opened this issue Mar 29, 2023 · 11 comments
Closed
1 task done

[Register add-on in translation system]: TeleNVDA #89

nvdaes opened this issue Mar 29, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@nvdaes
Copy link
Collaborator

nvdaes commented Mar 29, 2023

Add-on name

TeleNVDA

Add-on maintainer

@jmdaweb

Stable branch

  • Stable branch exists in add-on repo
@nvdaes nvdaes added the enhancement New feature or request label Mar 29, 2023
@nvdaes
Copy link
Collaborator Author

nvdaes commented Mar 29, 2023

Hi, GithUb Actions are failing. I can run scons locally, but here there's an error. Also, RD add-on could be registered properly and check passed. So this may contain amodified version of addonTemplate or something, and I don't know if this would be properly recognized when the addon is registered. Maybe, but then multiple version of the template would needto be addressed to run GitHub Actions, and I don't know if this can be done or how.
cc: @seanbudd

@jmdaweb
Copy link

jmdaweb commented Mar 29, 2023

Hi,
Note that this add-on needs Visual Studio to build an executable. The sconstruct file is slightly modified, but is almost identical to the one available on the add-on template. Are the actions based on another image without vs?
Regards.

@jmdaweb
Copy link

jmdaweb commented Mar 29, 2023

Confirmed. The action tries to use g++, and fails because windows.h is not available: https://github.com/nvaccess/mrconfig/actions/runs/4557071601/jobs/8038235472#step:6:43

@nvdaes
Copy link
Collaborator Author

nvdaes commented Mar 29, 2023 via email

@jmdaweb
Copy link

jmdaweb commented Mar 29, 2023

I also prefer any Linux variant rather than Windows on server environments. Ubuntu is a good choice to build most add-ons. However, TeleNVDA, NVDA Remote and other add-ons that need building executables from source require Windows, or a cross compiler on Linux, such as the MinGW toolchain. I see three possible solutions to this problem:

  • Extend the Ubuntu image as part of the setup process, installing the MinGW toolchain and modifying the required environment variables.
  • Switch to Windows with Visual Studio. I use it to build the add-on on the repo workflow without problems.
  • Modify the sconstruct file to ignore errors if compilation of url_handler fails, replacing the fatal error with a warning. I will study this choice.

Regards.

@seanbudd
Copy link
Member

Apologies for the difficulties.
To me, it seems like it makes the most sense to switch the workflow to Windows.
Do many add-on developers develop on linux?
Since NVDA is a Windows app it makes more sense to me that we build with Windows on this repo.

@nvdaes
Copy link
Collaborator Author

nvdaes commented Mar 30, 2023 via email

@seanbudd
Copy link
Member

@nvdaes ah - then we may run the risk that this also fails to build on the NV Access server. I will investigate this.

seanbudd added a commit that referenced this issue Mar 30, 2023
The check action failed for this add-on: #89, https://github.com/nvaccess/mrconfig/actions/runs/4557071601

This is due to the check running scons causing a full build of the add-on.
We cannot build add-ons in the server ubuntu environment, as some dependencies such as windows headers are required to build add-ons.
The translation system only needs to run scons pot in 01_addon2svn.sh.
As such, the full build is removed from the validation action
@seanbudd seanbudd reopened this Mar 30, 2023
@seanbudd
Copy link
Member

re-running CI

@github-actions
Copy link

The add-on and pot files were built from stable branch

@seanbudd
Copy link
Member

This has been registered now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants