Skip to content

Commit

Permalink
Revert "Excel: Limit row and column header searching to within the he…
Browse files Browse the repository at this point in the history
…ader cell and the right side of its region, though by avoiding using a call to Excel's currentRegion property."

This reverts commit 35f0f0d.
  • Loading branch information
michaelDCurran committed Apr 11, 2016
1 parent 507ee23 commit c14f16e
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions source/NVDAObjects/window/excel.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,12 +731,12 @@ def setAsHeaderCell(self,cell,isColumnHeader=False,isRowHeader=False):
return True

def _getMaxColumnNumberForHeaderCell(self,excelCell):
if not excelCell.text:
try:
r=excelCell.currentRegion
except COMError:
return excelCell.column
nextCell=excelCell.offset(0,1)
if not nextCell.text:
return nextCell.column
return excelCell.end(xlToRight).column+1
columns=r.columns
return columns[columns.count].column+1

def forgetHeaderCell(self,cell,isColumnHeader=False,isRowHeader=False):
if not isColumnHeader and not isRowHeader:
Expand All @@ -757,6 +757,12 @@ def forgetHeaderCell(self,cell,isColumnHeader=False,isRowHeader=False):
return True

def fetchAssociatedHeaderCellText(self,cell,columnHeader=False):
# #4409: cell.currentRegion fails if the worksheet is protected.
try:
cellRegion=cell.excelCellObject.currentRegion
except COMError:
log.debugWarning("Possibly protected sheet")
return None
for info in self.headerCellTracker.iterPossibleHeaderCellInfosFor(cell.rowNumber,cell.columnNumber,columnHeader=columnHeader):
textList=[]
if columnHeader:
Expand Down

0 comments on commit c14f16e

Please sign in to comment.