Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When a toggle button is focused, NVDA now reports when it is changed …
…from pressed to not pressed. Fixes #5441.
- Loading branch information
Showing
1 changed file
with
1 addition
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -670,6 +670,7 @@ def processNegativeStates(role, states, reason, negativeStates): | |
if reason == REASON_CHANGE: | ||
# We want to speak this state only if it is changing to negative. | ||
speakNegatives.add(STATE_DROPTARGET) | ||
speakNegatives.add(STATE_PRESSED) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
jcsteh
via email
Author
Contributor
|
||
# We were given states which have changed to negative. | ||
# Return only those supplied negative states which should be spoken; | ||
# i.e. the states in both sets. | ||
|
Hi,
Uh oh, perhaps this might be the cause of some regressions, including NVDA announcing "not pressed" even on checkboxes.
Would an overlay class solve this by detecting state change event? This may not work if the state change propagates to sibling controls on a screen. I ask because these toggle switches/buttons have a common trait: UIA item and UIA class name starts with "Toggle". Thanks.