Skip to content

Commit

Permalink
When a toggle button is focused, NVDA now reports when it is changed …
Browse files Browse the repository at this point in the history
…from pressed to not pressed.

Fixes #5441.
  • Loading branch information
jcsteh committed Dec 3, 2015
1 parent c36d560 commit f67746d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions source/controlTypes.py
Expand Up @@ -670,6 +670,7 @@ def processNegativeStates(role, states, reason, negativeStates):
if reason == REASON_CHANGE:
# We want to speak this state only if it is changing to negative.
speakNegatives.add(STATE_DROPTARGET)
speakNegatives.add(STATE_PRESSED)

This comment has been minimized.

Copy link
@josephsl

josephsl Dec 5, 2015

Collaborator

Hi,
Uh oh, perhaps this might be the cause of some regressions, including NVDA announcing "not pressed" even on checkboxes.
Would an overlay class solve this by detecting state change event? This may not work if the state change propagates to sibling controls on a screen. I ask because these toggle switches/buttons have a common trait: UIA item and UIA class name starts with "Toggle". Thanks.

This comment has been minimized.

Copy link
@jcsteh

jcsteh via email Dec 6, 2015

Author Contributor

This comment has been minimized.

Copy link
@Brian1Gaff

Brian1Gaff via email Dec 6, 2015

This comment has been minimized.

Copy link
@Brian1Gaff

Brian1Gaff via email Dec 7, 2015

# We were given states which have changed to negative.
# Return only those supplied negative states which should be spoken;
# i.e. the states in both sets.
Expand Down

0 comments on commit f67746d

Please sign in to comment.