New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Notifications and Actions Settings: Toggle buttons do not announce state change #5441

Closed
nvaccessAuto opened this Issue Oct 25, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@nvaccessAuto

nvaccessAuto commented Oct 25, 2015

Reported by jteh on 2015-10-25 22:25
STR:

  1. Open Notifications and Actions Settings.
  2. Press "Select which icons appear on the taskbar".
  3. Press one of the "pressed" (enabled) buttons.
  • Expected: NVDA should say "not pressed".
  • Actual: Nothing.
    1. Press the same button again.
  • Expected: NVDA should say "pressed".
  • Actual: Nothing.

This change does get reported by Narrator. Beyond this, we might also want to consider reporting these as toggle buttons and perhaps rethink the way we report toggle buttons altogether.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 1 by JamaicanUser on 2015-11-09 02:18
Interestingly, when moving away from the button when pressed and going back to it, if it has been toggled on/checked, NVDA reports the button as being pressed. This is what I mainly use to detect the state of some buttons.
In Jaws, as a side note, the state is reported as 'button checked' when activated and 'button' when not active. This seems to be more sensible in these cases.

nvaccessAuto commented Nov 9, 2015

Comment 1 by JamaicanUser on 2015-11-09 02:18
Interestingly, when moving away from the button when pressed and going back to it, if it has been toggled on/checked, NVDA reports the button as being pressed. This is what I mainly use to detect the state of some buttons.
In Jaws, as a side note, the state is reported as 'button checked' when activated and 'button' when not active. This seems to be more sensible in these cases.

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2016.1 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Dec 3, 2015

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Dec 3, 2015

Incubated in 445da15.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Dec 5, 2015

Collaborator

Hi,
A number of regressions were observed:

  1. "Not pressed" is spoken on checkboxes, certain buttons and so on.
  2. the toggle button for toggling certain settings such as Tablet Mode no longer announces pressed state (this could be just mine).
    Thanks.
Collaborator

josephsl commented Dec 5, 2015

Hi,
A number of regressions were observed:

  1. "Not pressed" is spoken on checkboxes, certain buttons and so on.
  2. the toggle button for toggling certain settings such as Tablet Mode no longer announces pressed state (this could be just mine).
    Thanks.
@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Dec 5, 2015

Collaborator

Hi,
Upon further investigation, it appears toggling Tablet Mode and other items from Settings app does produce the intended result, with the first regression still remaining. Thanks.

Collaborator

josephsl commented Dec 5, 2015

Hi,
Upon further investigation, it appears toggling Tablet Mode and other items from Settings app does produce the intended result, with the first regression still remaining. Thanks.

jcsteh added a commit that referenced this issue Dec 9, 2015

Don't report "not pressed" inappropriately for checkboxes and buttons…
… which aren't toggle buttons.

"Not pressed" is now only reported for toggle buttons. UIA buttons with the toggle pattern now get a role of toggle button.
Re #5441. Fixes #5580.
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Dec 9, 2015

Incubated in 85403ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment