-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Div with role checkbox not reading checked/unchecked on performing action #10484
Comments
I am not able to reproduce this in NVDA alpha-19159,cde557d5. |
I am trying in Chrome browser. As for the rows it is reading out "space" when pressing space. |
Ok I confirm I can reproduce this issue only for the checkbox "select all items" in Chrome as well as in Firefox: CC: @jcsteh. |
@Adriani90 @jcsteh |
I can reproduce it, but I don't know for certain what's causing it. My
hunch is that it has something to do with the fact that when you toggle
that checkbox, it toggles the checkboxes for every other row on that page.
Because there are a lot of rows, that is a *lot* of stateChange events.
Perhaps they're being throttled somewhere, very likely NVDA (since handling
too many events causes performance problems). If that's the case, I don't
really know what can be done here.
|
@jcsteh |
@sandeepnmenon see the comment from Jamie above. |
So is that the case? |
@Adriani90 @jcsteh |
cc: @feerrenrut which priority would you assign to this one? |
There isn't a clear way to deal with this situation. I also expect it's possible for a web author to develop a work around, probably with an improved experience. For instance, I would prefer to hear 200 items checked, rather than just checked. If we can verify that NVDA is indeed throwing away a flood of stateChange events. One possible solution worth prototyping is to see if we can determine that one of the stateChange events relates to the current focus, and keep that one. In terms of priority, I think a P3. I don't expect that it is happening often, and it is possible to read the state after it has changed, and I suspect it's possible to work around this issue. @sandeepnmenon We don't know for sure we can fix this, it will require investigation. It's severity means that is not going to jump in front of other work. Please don't rely on this being fixed in the short term. |
If I'm right about events being dropped as per #10484 (comment), #11077 should fix this. |
It seems I'm correct about events being dropped. I have a branch which drops events except those targeted at specific objects (the focus, etc.). With that change, this test case works as expected. This is still pretty experimental, though. I just thought it worth noting for anyone looking into this. |
@sandeepnmenon it looks like the codepen has changed since your initial comment. Could you please restore it? |
Dear @sandeepnmenon, another friendly reminder to restore the example in the initial message of this issue. |
@LeonarddeR Apologies for the late reply since I am not longer working on React accessibility. Unfortunately I was not able to setup NVDA in ubuntu. |
No problem at all @sandeepnmenon, many thanks for responding again. |
Steps to reproduce:
Open following codepen : https://codepen.io/sandeepnmenon/pen/NWKOgYo
Tab till the check button in the header of the table.
Check/Uncheck using space button
Actual behavior:
NVDA not reading checked/unchecked
Expected behavior:
NVDA should read checked/unchecked
System configuration
NVDA version: 2019.2.1
Windows version: Windows 10
Name and version of other software in use when reproducing the issue:
React: 16.8.6
Office fabric: 7.60.0
Does the issue still occur after restarting your PC?: Yes
The text was updated successfully, but these errors were encountered: