alpha builds: many error messages in the log when opening Adobe Reader #11568
Assignees
Labels
app/adobe/acrobat
blocked
bug/regression
p2
https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
Comments
aaclause
changed the title
|
I can reproduce this, though other than the initial errors, I didn't notice any broken behavior. After adobe reader finished loading the errors stopped (took less than a second) and nvda seemed to work fine in adobe reader. @Andre9642 did you find anything else broken? |
|
It would be good to investigate a little, but I don't want to hold back the release unless there is a demonstrable regression in behavior. |
|
For reference I cannot reproduce this with NVDA version alpha-20851,f33664ec running as a portable on Windows 7 X64 and with Reader DC version 20.012.20043; |
|
Interesting, that was the build that I used to reproduce it on Win 10 2004 with the same version of Reader. Details: |
|
@feerrenrut Would you be able to generate a portable version from your installed Alpha and try to reproduce with it? Perhaps portable vs installed makes a difference here. |
|
I actually just ran from the launcher, I suspect that the difference is related to Windows. |
|
Note that all the nvWave / winmm messages go away with pr #11582 which has been merged to beta already. However, those rpc messages are quite concerning and I shall look into them. |
|
But assuming the rpc errors were also present in NVDA 2020.2 and there is no negative affect, then I agree we should not hold back the release of 2020.3 for this. |
|
It is recommended that Milestones for Issue 11568 be revised for 2020.4, as NVDA 2020.3 will be released in rc soon. |
|
This issue becomes more annoying. Indeed I'm unable to start Adobe Reader since several weeks because it crashes at startup with NVDA turned on (so I have to run it without NVDA). Log |
|
@aaclause From the initial issue description it looks like this regressed during 2020.3 development cycle. Would you be able to confirm that Acrobat Reader can be started with 2020.2 and if so perhaps bisect the offending commit? |
|
@lukaszgo1 same behavior with NVDA 2020.4, 2020.3, 2020.2, 2020.1 (tested with portable versions). I suspect my version of windows is at fault (latest insider build). |
feerrenrut
added
the
p2
|
May be related to #12920 |
5 tasks
michaelDCurran
added a commit
that referenced
this issue
Mar 3, 2022
Fixes #11568 Partial fix for #12920 Summary of the issue: Recent versions of Adobe Reader introduced a Protected Mode, where by the Adobe Acrobat process has less privileges and is sandboxed. This ensures that insecure PDFs do not have a chance to affect the rest of the Operating System. By default Adobe Reader is configured to enter its Protected mode on start-up, and to set the 'isAppContainer' attribute on its process token. There seems to be a bug however, either in Adobe Reader, the Windows OS, or NVDA (NV access and Adobe cannot be sure) that causes the Adobe Reader process to become unstable when NVDA tires to register IAccessible2. Specifically, the call to CoGetPSClsid seems to start making things unstable. The further call to CoRegisterPSClsid fails, and then eventually the process completely crashes randomly in places such as TSF initialization. The upshot is that If Adobe Reader is started when NVDA is running, many errors are written to NVDA's log, and Adobe Reader closes straight away. Description of how this pull request fixes the issue: NVDAHelper's IAccessible2 registration code now checks if the process token has the 'IsAppContainer' attribute, and of so refuses to install IAccessible2 support. Note that Adobe Reader itself does not require IAccessible2 to function. Also, the 'IsAppContainer' is only set on very heavily sandboxed sitations, and is not the same as the app container that is used for Windows Desktop Bridge apps. Thus, refusing to install IAccessible2 into processes with the 'IsAppContainer' attribute has no other known side affects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
Just open Adobe Reader.
Actual behavior:
Following errors occur:
Show/hide
Expected behavior:
No error
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
alpha-20840,c8d6ab95
Windows version:
10 Insider (64-bit) build 20206.1000
Name and version of other software in use when reproducing the issue:
Adobe Acrobat Reader DC 20.12.20043.396433'
Other information about your system:
Other questions
Does the issue still occur after restarting your computer?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
No problem with 2020.2. Present with several alpha builds.
If addons are disabled, is your problem still occuring?
Yes
Did you try to run the COM registry fixing tool in NVDA menu / tools?
Yes
The text was updated successfully, but these errors were encountered: