Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture overrides broken in NVDA 2022.2.1 #14065

Closed
LeonarddeR opened this issue Aug 25, 2022 · 3 comments · Fixed by #14066
Closed

Gesture overrides broken in NVDA 2022.2.1 #14065

LeonarddeR opened this issue Aug 25, 2022 · 3 comments · Fixed by #14066
Assignees
Labels
bug/regression component/braille feature/input-gestures p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@LeonarddeR
Copy link
Collaborator

Steps to reproduce:

Add the following gesture overrides for the brailliant driver. Providing the gestures.ini entries for convenience

[globalCommands.GlobalCommands]
braille_scrollForward = br(brailliantb):down
braille_scrollBack = br(brailliantb):up
braille_previousLine = br(brailliantb):left
braille_nextLine = br(brailliantb):right

Actual behavior:

Overrides are ignored arbitrarily. For example, on several restarts of nvda:

n up left right down
1 braille_previousLine braille_scrollBack braille_scrollForward braille_scrollForward
2 braille_previousLine braille_previousLine braille_nextLine braille_nextLine
3 braille_previousLine braille_previousLine braille_scrollForward braille_scrollForward

Expected behavior:

Gestures as provided in gestures.ini are always mapped

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2022.2.1 and recent alpha

Windows version:

Windows 11 22621.105

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

Humanware Mantis connected via USB. Also reported by @dkager when using a Brailliant.

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, does not occur with 2022.2

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@LeonarddeR
Copy link
Collaborator Author

Probably related to changing globalMapScripts.extend to globalMapScripts.update in scriptHandler.

@dkager
Copy link
Collaborator

dkager commented Aug 25, 2022

Thanks to @LeonarddeR for finding the root of the problem so quickly! I looked at the diff from 2022.2, but I overlooked this change. That said, perhaps these changes do not belong in a security point release in the first place.

seanbudd pushed a commit that referenced this issue Aug 26, 2022
…n a list instead of a set (#14066)

Fixes #14050

Summary of the issue:
Overriding/remapping existing braille display gestures was broken in NVDA 2022.2.1.

Description of user facing changes
Gesture overrides work again in the mentioned case in #14065

Description of development approach
Revert an uncessary and seemlinly undocumented change in scriptHandler. It would help if we could clear up how this change ended up in this release.
@seanbudd
Copy link
Member

This was closed by #14066 correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression component/braille feature/input-gestures p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
4 participants