Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eSpeak for 2023.1 #14281

Closed
1 task done
seanbudd opened this issue Oct 23, 2022 · 1 comment · Fixed by #14483 or #14517
Closed
1 task done

Update eSpeak for 2023.1 #14281

seanbudd opened this issue Oct 23, 2022 · 1 comment · Fixed by #14483 or #14517
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.1

Comments

@seanbudd
Copy link
Member

seanbudd commented Oct 23, 2022 •
edited

Janitorial task

Updating eSpeak should also close
@seanbudd seanbudd added this to the 2023.1 milestone Oct 23, 2022
@seanbudd seanbudd added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Oct 25, 2022
@seanbudd
Copy link
Member Author

See also: #13875 (comment), fix up this when updating

@seanbudd seanbudd mentioned this issue Dec 29, 2022
Merged
6 tasks
seanbudd added a commit that referenced this issue Jan 4, 2023
@seanbudd
Update eSpeak to a51235aa commit (#14483)
3183fce 
Closes #14281
Closes #14241
Addresses #13875 (comment)

Summary of the issue:
Janitorial update of eSpeak.
Removes a workaround added to handle a bug with eSpeaks BreakCommand implementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment)

Description of user facing changes
eSpeak is updated.
Fixes pronunciation of large numbers (#14241).

Description of development approach
Dropped strength for eSpeak BreakCommand attribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak.
@seanbudd seanbudd mentioned this issue Jan 5, 2023
Merged
6 tasks
@seanbudd seanbudd reopened this Jan 5, 2023
seanbudd added a commit that referenced this issue Jan 6, 2023
@seanbudd
Update eSpeak to a51235aa commit (#14517)
6dd9002 
#14483 was reverted via #14516 due to an issue with rate boost.
eSpeak changed the compilation flag, and that change wasn't in the Makefile.am diff, so it was missed.
This is fixed in 7e558da

Link to issue number:
Closes #14281
Closes #14241
Addresses #13875 (comment)

Summary of the issue:
Janitorial update of eSpeak.
Removes a workaround added to handle a bug with eSpeaks BreakCommand implementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment)

Description of user facing changes
eSpeak is updated.
Fixes pronunciation of large numbers (#14241).

Description of development approach
Dropped strength for eSpeak BreakCommand attribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak.

Janitorial update
Followed instructions in include/espeak.md.
Checked the following diffs.

cd include/espeak
git diff a51235aa b17ed2d6 src/windows/config.h
git diff a51235aa b17ed2d6 Makefile.am
Addressed the following eSpeak changes:

Introduction of langopts.c: espeak-ng/espeak-ng@4a28902
Fix up of code standards: change DINCLUDE to DUSE: espeak-ng/espeak-ng@ca1f590
Note that eSpeak has changed MBROLA compilation, does not affect our build: espeak-ng/espeak-ng@78ac6c4
@seanbudd seanbudd mentioned this issue Feb 26, 2023
Merged
6 tasks
seanbudd added a commit that referenced this issue Feb 26, 2023
@seanbudd
update eSpeak for 2023.1beta2 (#14675)
e38b90b 
Fixes #14650

Summary of the issue:
#14281 introduced a bug with eSpeak espeak-ng/espeak-ng#1660
This was fixed.

Description of user facing changes
Description of development approach
Janitorial task to update eSpeak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.1
Development

Successfully merging a pull request may close this issue.

Update eSpeak to a51235aa commit nvaccess/nvda
Update eSpeak to a51235aa commit nvaccess/nvda
1 participant
@seanbudd