NVDA does not speak after add-on installation until it is restarted

[CyrilleB79]

Steps to reproduce:

1. Take any add-on, e.g. the simple add-on Say Product Name and Version
2. In an NVDA without any add-on installed, install your add-on and restart
3. Once NVDA is restarted, open the add-on manager dialog
4. Alt+Tab to Windows Explorer, keeping Add-on manager window opened in the background
5. Install again your add-on from Windows Explorer
6. When prompted to restart, press Yes

Actual behavior:

After step 6., NVDA does not restart and does not speak anymore. Windows is responsive though. You need to press Yes again (with no vocal feedback) to have it restarted.

Also, the following error is found in the log:

ERROR - core.restart (15:01:57.486) - MainThread (2692):
NVDA already in process of exiting, this indicates a logic error.

Expected behavior:

NVDA should read the dialog box.

The error should not appear in the log.

NVDA logs, crash dumps and other attachments:

nvda-old.log

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2022.4

Windows version:

Windows 10 20H2 (AMD64) build 19042.2364

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Issue reproduced on the following older versions:

• 2021.2 portable
• 2022.1 portable

If NVDA add-ons are disabled, is your problem still occurring?

N/A but tested with two different add-ons, to exclude the possibility of an issue with the add-on.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Not tested, unrelated.

[FalkoBabbage]

Adding a check for core._hasShutdownBeenTriggered in gui.addonGui.promptUserForRestart would solve this problem. But I am not sure if a check on the exitCode from globalVars is preferred over checking a "private" core property.

[seanbudd]

Adding a check for core._hasShutdownBeenTriggered in gui.addonGui.promptUserForRestart would solve this problem. But I am not sure if a check on the exitCode from globalVars is preferred over checking a "private" core property.

I think this is fine, but it's probably more appropriate to add the check in gui.messageBox if that is where the issue is.

[CyrilleB79]

Note: The issue is still present in the add-on store project of PR #13985.

[XLTechie]

@CyrilleB79

Note: The issue is still present in the add-on store project of PR #13985.

Have you tested the latest try build? I didn't try this STR exactly, but a similar one which was replicating this before, no longer is with the latest build.

[CyrilleB79]

No I have not tested, sorry. I had just written this not to avoid closing this issue in case all add-on manager related issues should be closed when the store is merged and working.

In any case this issue (if it still exists) should not be considered blocking for PR #13985. Since #13985 is not yet merged, my recommendation is just to double-check when the PR is merged that this issue is not present anymore in the add-on store before closing.

[CyrilleB79]

This issue is still present with the add-on store in NVDA 2023.2.