Add Unicode braille support #14548
Merged
Add Unicode braille support #14548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Unicode braille occurs within text — for instance, ⠐⠣⠃⠗⠇⠐⠜ says "(braille)" in UEB — NVDA currently just skips over the braille entirely. This makes it at least pronounce the braille cells. Because this is pronunciation for the Unicode characters themselves, it is braille-code-agnostic and just pronounces individual braille characters in the usual "dot 3 5 7" way. If the input table is known, this default should get overridden, but it's at least a fallback, and allows one to read text that's _about_ braille. I've left level & preserve in defaults.
5 tasks
See test results for failed build of commit 340f6b6f38 |
michaelDCurran
requested changes
Jan 30, 2023
|
@michaelDCurran I've re-ordered it now |
michaelDCurran
approved these changes
Feb 14, 2023
6 tasks
seanbudd
pushed a commit
that referenced
this pull request
Mar 23, 2023
NVDA doesn't announce the symbol that macs use to represent the mac "Option" key ("⌥") (see Mac keyboard shortcuts documentation).
Description of user facing changes
Adds a symbol description for this symbol ("mac Option key" announced at "none" level and up, similar to the existing entry for "mac Command key" at the "none" level for symbol "⌘").
Description of development approach
Followed the "Defining Symbol Information" developer documentation, using the existing "mac Command key" entry and similar recent PR #14548 as examples
Testing strategy:
Didn't attempt to adjust any automated tests (assumed they were already present generally for symbol pronunciation). Manually verified reading by:
runnvda.bat from this branch
Browse to Mac keyboard shortcuts docs
Read through the content under the "Mac keyboard shortcuts" H1, particularly the list item with content "Option (or Alt) ⌥"
Verify that the symbol is read out as "mac Option key" as expected
Change NVDA's "Settings > Speech > Punctuation/symbol level" to "none" and repeat above steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13778
Supersedes #13777
Summary of the issue:
If Unicode braille occurs within text — for instance, ⠐⠣⠃⠗⠇⠐⠜ says "(braille)" in UEB — NVDA currently just skips over the braille entirely. This is because it is not included in symbols.dic
Description of user facing changes
Unicode braille symbols are now announced.
Description of development approach
The sequence method attempted in #13777 fails in some scenarios as outlined in #13777 (comment)
Testing strategy:
Test reading braille symbols in symbol file
Known issues with pull request:
None
Change log entries:
New features:
Added pronunciation of Unicode braille symbols such as "⠐⠣⠃⠗⠇⠐⠜"
Code Review Checklist: