Add pronunciation of Mac Option key symbol "⌥"#14682
Merged
Merged
Conversation
Contributor
Author
|
Hi @seanbudd , Just wanted to give a friendly ping on this and to clarify that this PR is marked as a "Draft" only because that's what the PR template suggests to do - I think it's ready for review. Is there anything further action you'd like me to take to help move this forward? |
Collaborator
|
The initial draft mode is only for the first submission. When you're done with
edits, mark it as ready for review.
|
Contributor
Author
|
Apologies, I misunderstood the instructions. Thanks for clarifying, @XLTechie! |
seanbudd
approved these changes
Mar 23, 2023
Contributor
|
Nice to see you contributing here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
n/a (minor/trivial change)
Summary of the issue:
NVDA doesn't announce the symbol that macs use to represent the mac "Option" key ("⌥") (see Mac keyboard shortcuts documentation).
Description of user facing changes
Adds a symbol description for this symbol ("mac Option key" announced at "none" level and up, similar to the existing entry for "mac Command key" at the "none" level for symbol "⌘").
Description of development approach
Followed the "Defining Symbol Information" developer documentation, using the existing "mac Command key" entry and similar recent PR #14548 as examples
Testing strategy:
Didn't attempt to adjust any automated tests (assumed they were already present generally for symbol pronunciation). Manually verified reading by:
runnvda.batfrom this branchKnown issues with pull request:
Mac commonly uses a few other symbols to represent keyboard modifiers (eg, when displaying keyboard shortcut hints), per the Mac keyboard shortcuts documentation. I've left the other cases alone because they either:
Change log entries:
Code Review Checklist: