Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eSpeak for 2023.1beta2 #14675

Merged
merged 2 commits into from
Feb 26, 2023
Merged

update eSpeak for 2023.1beta2 #14675

merged 2 commits into from
Feb 26, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Feb 26, 2023

Link to issue number:

Fixes #14650

Summary of the issue:

#14281 introduced a bug with eSpeak espeak-ng/espeak-ng#1660
This was fixed.

Description of user facing changes

Description of development approach

Janitorial task to update eSpeak

Testing strategy:

Known issues with pull request:

Change log entries:

refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner February 26, 2023 20:52
@seanbudd seanbudd changed the base branch from master to beta February 26, 2023 20:53
@seanbudd seanbudd added this to the 2023.1 milestone Feb 26, 2023
@AppVeyorBot
Copy link

See test results for failed build of commit bc30b508ea

@seanbudd seanbudd merged commit e38b90b into beta Feb 26, 2023
@seanbudd seanbudd deleted the updateEspeakf520fecb branch February 26, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using eSpeak-ng on NVDA2023.1beta1 in Italian language.
3 participants