Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore userConfig when running checkPot translation comments check #14820

Closed
seanbudd opened this issue Apr 11, 2023 · 0 comments · Fixed by #14867
Closed

Ignore userConfig when running checkPot translation comments check #14820

seanbudd opened this issue Apr 11, 2023 · 0 comments · Fixed by #14867
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.2

Comments

@seanbudd
Copy link
Member

Steps to reproduce:

  1. Have add-ons installed to a source copy of NVDA
  2. Ensure the add-ons contain translator errors, e.g. translatable strings without comments
  3. Run scons checkpot
  4. Note that uncommented translation strings in userConfig are raised as checkpot errors.

Actual behavior:

Translation string errors are raised for issue with add-ons

Expected behavior:

Including userConfig in the translation comment check should be disabled by default
including userConfig should be an option when running scons checkpot, and disabled by default.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Source
@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers triaged Has been triaged, issue is waiting for implementation. labels Apr 18, 2023
@CyrilleB79 CyrilleB79 mentioned this issue Apr 23, 2023
Merged
6 tasks
seanbudd pushed a commit that referenced this issue Apr 26, 2023
@CyrilleB79
Do not include userConfig folder in pot sources (#14867)
a154cfa 
Fixes #14820

Summary of the issue:
The checkPot script used to check translation comments also checks the subfolder userConfig. This is not correct since the code in userConfig is not NVDA's code but code from add-ons or from the scratchpad.

Description of user facing changes
The checkPot script does not check the userConfig subfolder anymore.

Description of development approach
In addition to COM interface folder, the userConfig folder is also excluded from the check.
Also the exclusion of these two folders is made in the folders' list rather than in the Glob expression since scons' Glob does not support filtering recursively subvolders; this is also probably more efficient to filter the folders than using Glob for each file.
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

Do not include userConfig folder in pot sources CyrilleB79/nvda
2 participants
@seanbudd @nvaccessAuto