Do not include userConfig folder in pot sources

[CyrilleB79]

Link to issue number:

Fixes #14820

Summary of the issue:

The checkPot script used to check translation comments also checks the subfolder userConfig. This is not correct since the code in userConfig is not NVDA's code but code from add-ons or from the scratchpad.

Description of user facing changes

The checkPot script does not check the userConfig subfolder anymore.

Description of development approach

• In addition to COM interface folder, the userConfig folder is also excluded from the check.
• Also the exclusion of these two folders is made in the folders' list rather than in the Glob expression since scons' Glob does not support filtering recursively subvolders; this is also probably more efficient to filter the folders than using Glob for each file.

Testing strategy:

Manual tests:

• The checkPot script still find no error in NVDA's code.
• If userConfig contains add-ons with missing translator's comments, the checkPot script does not issue errors anymore.

Unit tests: should still pass.

Known issues with pull request:

None

Change log entries:

For Developers

• The checkPot script will not check the userConfig subfolder anymore.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/06a7hgs8hkvi9d6m/artifacts/output/nvda_snapshot_pr14867-28145,d716c6a1.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.9,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 23.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 21.3,
  FINISH_END 0.2

See test results for failed build of commit d716c6a16a

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/uoj65s78no9pace1/artifacts/output/nvda_snapshot_pr14867-28149,fd0f4373.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 22.8,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 17.8,
  FINISH_END 0.1

See test results for failed build of commit fd0f4373aa

[CyrilleB79]

@seanbudd, I am marking this PR as ready although system tests fail, since it seems unrelated.

Note: the system test with Chrome seem to fail always more frequently. It's an issue for contributors, especially occasional ones who are not aware of the recurrent failing status of these tests.

[seanbudd]

thanks @CyrilleB79