Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkable state change is not reported automatically in thunderbird when selecting columns to display #16323

Closed
burmancomp opened this issue Mar 19, 2024 · 6 comments · Fixed by #16400
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@burmancomp
Copy link
Contributor

burmancomp commented Mar 19, 2024

Steps to reproduce:

  • open thunderbird inbox
  • move to columns to display button and press it
  • navigate in menu to some item (column) and change its state (for example press enter)

Actual behavior:

State changes but it is not reported automatically in speech or braille.

Expected behavior:

State change should be automatically reported in speech and braille.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

installed/running from source

NVDA version:

2023.3.4 and based on current main branch

Windows version:

w10 22h2

Name and version of other software in use when reproducing the issue:

thunderbird 115.9.0

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

@Jykke67
Copy link

Jykke67 commented Mar 19, 2024

Yes, I have noticed the very same issue.

When the Mozilla Enhancements add-on was used with older versions of Thunderbird, the state changes of columns were automatically reported. Therefore I have to downgrade to an old version of TB in order to change the order of shown columns and then return to the latest version. When downgrading to the old version of TB I have to enable the Mozilla Enhancements add-on and disable it when returning to the latest version of TB, which is a bit complex even for an advanced user of NVDA.

@XLTechie
Copy link
Collaborator

XLTechie commented Mar 19, 2024 via email

@burmancomp
Copy link
Contributor Author

One solution would be to add event_nameChange to IAccessible.mozilla.Mozilla class. If stateChange event is executed in event_nameChange state change (checked/unchecked) is reported both in speech and braille (tested locally).

I am not familiar with app modules but thunderbird app module would sound logical place to do this.

I have tested this locally but I have not succeeded with nameChange event in thunderbird app module for now.

No problem if this is something somebody else wants to fix, and if there is more appropriate approach.

@burmancomp
Copy link
Contributor Author

I am not familiar with app modules but thunderbird app module would sound logical place to do this.

I have tested this locally but I have not succeeded with nameChange event in thunderbird app module for now.

Now it seems to work.

@burmancomp
Copy link
Contributor Author

Is there something I could do to get this issue triaged? I think I have implementation for this (I do not say it is appropriate but it seems to work somewhat).

@CyrilleB79
Copy link
Collaborator

Cc @seanbudd for triage

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Apr 16, 2024
seanbudd pushed a commit that referenced this issue Apr 16, 2024
fixes #16323

Summary of the issue:
When selecting columns to display in Thunderbird message list, column state (checked or not checked) is not automatically spoken or shown in braille when state changes.

Description of user facing changes
Column state is automatically spoken and shown in braille when it changes.

Description of development approach
Added nameChange event to thunderbird.AppModule.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants