Show state change when selecting column to display in Thunderbird message list#16400
Merged
seanbudd merged 7 commits intonvaccess:masterfrom Apr 16, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #16323
Summary of the issue:
When selecting columns to display in Thunderbird message list, column state (checked or not checked) is not automatically spoken or shown in braille when state changes.
Description of user facing changes
Column state is automatically spoken and shown in braille when it changes.
Description of development approach
Added nameChange event to
thunderbird.AppModule.Testing strategy:
Manual testing.
Known issues with pull request:
I have reported to ThunderbirdPlusG5 addon authors that if this change is accepted, executing parent class nameChange event could be enough to get this change work with addon.
Code Review Checklist: