Skip to content

Show state change when selecting column to display in Thunderbird message list#16400

Merged
seanbudd merged 7 commits intonvaccess:masterfrom
burmancomp:selectColumnsInThunderbird
Apr 16, 2024
Merged

Show state change when selecting column to display in Thunderbird message list#16400
seanbudd merged 7 commits intonvaccess:masterfrom
burmancomp:selectColumnsInThunderbird

Conversation

@burmancomp
Copy link
Contributor

@burmancomp burmancomp commented Apr 16, 2024

Link to issue number:

fixes #16323

Summary of the issue:

When selecting columns to display in Thunderbird message list, column state (checked or not checked) is not automatically spoken or shown in braille when state changes.

Description of user facing changes

Column state is automatically spoken and shown in braille when it changes.

Description of development approach

Added nameChange event to thunderbird.AppModule.

Testing strategy:

Manual testing.

Known issues with pull request:

I have reported to ThunderbirdPlusG5 addon authors that if this change is accepted, executing parent class nameChange event could be enough to get this change work with addon.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @burmancomp

@seanbudd seanbudd merged commit ab2cd7d into nvaccess:master Apr 16, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 16, 2024
@burmancomp burmancomp deleted the selectColumnsInThunderbird branch April 17, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkable state change is not reported automatically in thunderbird when selecting columns to display

3 participants