Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many blank lines in browse mode after #16471 merge #16554

Closed
LeonarddeR opened this issue May 15, 2024 · 1 comment · Fixed by #16585
Closed

Many blank lines in browse mode after #16471 merge #16554

LeonarddeR opened this issue May 15, 2024 · 1 comment · Fixed by #16585
Assignees
@SaschaCowley
Labels
bug/regression feature/browse-mode p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.3

Comments

@LeonarddeR
Copy link
Collaborator

Steps to reproduce:

  1. Open Report aria-label and aria-description even when parent has no visible children #16471
  2. Go to the Code Review Checklist: heading
  3. Press down arrow

Actual behavior:

NVDA reports three empty lines below the heading before it reports the first list item

Expected behavior:

NVDA directly moves to the first list item.

Additional context

There are also empty lines added in the github pull request overview, for example.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-31919,383b2044

Windows version:

Windows 11 23H2

Name and version of other software in use when reproducing the issue:

Firefox 125.0.3

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, I reverted a1848dd when running from source and the issue disappeared.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A
@LeonarddeR LeonarddeR mentioned this issue May 15, 2024
Merged
5 tasks
@Adriani90
Copy link
Collaborator

cc: @SaschaCowley

@seanbudd seanbudd added this to the 2024.3 milestone May 16, 2024
@seanbudd seanbudd added bug/regression p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. feature/browse-mode labels May 16, 2024
@SaschaCowley SaschaCowley mentioned this issue May 22, 2024
Merged
5 tasks
seanbudd pushed a commit that referenced this issue May 23, 2024
@SaschaCowley
Fix regression where many blank lines were reported in browse mode (#…
ce137cd 
…16585)

Fixes #16554

Summary of the issue:
#16471 introduced a regression whereby many blank lines were reported in browse mode.

Description of user facing changes
Extraneous blank lines are no longer reported in browse mode.

Description of development approach
Updated checks in gecko_ia2.cpp:

Check that the length of name is non-zero (SysStringLen returns 0 if the BSTR passed is null)
Added check that description's value is not the empty string, as checking that it has a value is necessary but not sufficient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaCowley SaschaCowley

Labels
bug/regression feature/browse-mode p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.3
Development

Successfully merging a pull request may close this issue.

Fix regression where many blank lines were reported in browse mode SaschaCowley/nvda
4 participants
@LeonarddeR @seanbudd @SaschaCowley @Adriani90