Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find (NVDA+control+f) Announce Selected Candidate Problem #3726

Closed
nvaccessAuto opened this issue Dec 18, 2013 · 6 comments
Closed

Find (NVDA+control+f) Announce Selected Candidate Problem #3726

nvaccessAuto opened this issue Dec 18, 2013 · 6 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Dec 18, 2013

Reported by surfer0627 on 2013-12-18 01:54
Hello developers,
In browse mode, I press (NVDA+control+f), and then pop up a dialog in which I type some text to find.

I use input method (chinese New Phonetic 2010) to type some text, and press arrow down twice to select candidate.

announce: NVDA and the selected candidate

expected: candidate only

This case occurred in version 2013.3. It is okay in 2013.2.

Thank you.

Blocking #3763

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 18, 2013

Comment 1 by surfer0627 on 2013-12-18 03:28
To test this case, please change language to zh_TW. This settings allows NVDA to report selected candidate.

Preferences --> General settings...

Thank you.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 14, 2014

Comment 2 by jteh on 2014-01-14 08:13
Regression caused by 1889cfe.
Changes:
Milestone changed from None to next

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 14, 2014

Comment 4 by James Teh <jamie@... on 2014-01-14 08:26
In [64f4a14]:

When entering Asian input into a control within NVDA itself (e.g. the browse mode Find dialog), "NVDA" is no longer incorrectly reported in place of the actual candidate.

When determining whether to fudge the name for the NVDA menu, the code wasn't checking whether the saved NVDA menu identity was None before comparing it. This meant that anything with an IAccessibleIdentity of None was getting the name "NVDA" before the NVDA menu was first opened.
Aside from Asian input, this seems to affect message dialogs in wxPython 3.
Re #3726.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 14, 2014

Comment 5 by James Teh <jamie@... on 2014-01-14 08:27
In [9ee4bff]:

Merge branch 't3726' into next

Incubates #3726.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 30, 2014

Comment 7 by James Teh <jamie@... on 2014-01-30 07:11
In [437343a]:

When entering Asian input into a control within NVDA itself (e.g. the browse mode Find dialog), "NVDA" is no longer incorrectly reported in place of the actual candidate.

When determining whether to fudge the name for the NVDA menu, the code wasn't checking whether the saved NVDA menu identity was None before comparing it. This meant that anything with an IAccessibleIdentity of None was getting the name "NVDA" before the NVDA menu was first opened.
Aside from Asian input, this seems to affect message dialogs in wxPython 3.
Fixes #3726.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 30, 2014

Comment 8 by jteh on 2014-01-30 07:12
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants