New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report formatting when moving to Excel cells #4878

Closed
nvaccessAuto opened this Issue Feb 3, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Feb 3, 2015

Reported by jteh on 2015-02-03 06:44
(Spun off #3044.)

It'd be useful to hear formatting (such as borders) when you enter Excel cells if the appropriate formatting preferences are enabled, rather than having to explicitly press NVDA+f. To do this:

  1. We need to make speech.speakObject use the TextInfo similar to the way it does for editable text fields.
  2. The current code for doing this only speaks the text last in this case, so it also needs to account for speaking it first for table cells.
  3. We should probably introduce a reportTextContent attribute or similar to make speakObject use the TextInfo instead of the value, rather than continually hard-coding new cases in speech.speakObject.

Note that though this is for Excel, it's mostly core work.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 10, 2015

Comment 1 by Michael Curran <mick@... on 2015-09-10 04:39
In commit dbc72cd:
ExcelCell NVDAObject: override reportFocus to also announce format changes, caching them on the sheet. This is temporary for Excel re #4878, before a bigger speech refactor.

nvaccessAuto commented Sep 10, 2015

Comment 1 by Michael Curran <mick@... on 2015-09-10 04:39
In commit dbc72cd:
ExcelCell NVDAObject: override reportFocus to also announce format changes, caching them on the sheet. This is temporary for Excel re #4878, before a bigger speech refactor.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 10, 2015

Comment 2 by Michael Curran <mick@... on 2015-09-10 04:41
In commit 8c4137c:
Merge branch 't4878' into next. Incubates #4878
Changes:
Added labels: incubating

nvaccessAuto commented Sep 10, 2015

Comment 2 by Michael Curran <mick@... on 2015-09-10 04:41
In commit 8c4137c:
Merge branch 't4878' into next. Incubates #4878
Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 6, 2015

Comment 3 by Michael Curran <mick@... on 2015-10-06 05:26
In commit b2715ca:
Merge branch 't4878'. Fixes #4878
Changes:
Removed labels: incubating
State: closed

nvaccessAuto commented Oct 6, 2015

Comment 3 by Michael Curran <mick@... on 2015-10-06 05:26
In commit b2715ca:
Merge branch 't4878'. Fixes #4878
Changes:
Removed labels: incubating
State: closed

michaelDCurran added a commit that referenced this issue Nov 23, 2015

ExcelCell NVDAObject: override reportFocus to also announce format ch…
…anges, caching them on the sheet. This is temporary for Excel re #4878, before a bigger speech refactor.

michaelDCurran added a commit that referenced this issue Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment