New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard accelerators to two Mouse Settings dialog options #4916

Closed
nvaccessAuto opened this Issue Feb 13, 2015 · 12 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Feb 13, 2015

Reported by bhavyashah on 2015-02-13 10:06
In the Mouse Settings dialog (NVDA menu > Preferences submenu > Mouse Settings... or simply NVDA + Ctrl + M), there are two options without any keyboard accelerators.
Follow are those two options with possible keyboard accelerators:
Play audio coordinates when mouse moves - Alt + a
Brightness controls audio coordinates volume - Alt + b
I understand the triviality of this ticket in comparison to other tickets, but just reporting for future consideration...

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 13, 2015

Comment 1 by nvdakor on 2015-02-13 17:27
Hi,
Are there other tickets like this? If so, I'd like to combine them into a single ticket to address missing shortcut problem.
For anyone willing to implement this, you need to modify settings dialogs module from GUI package. I'd wait until 2015.1 is out before working on this (2015.1 is in translatable string freeze at the moment, and settings items are translatable strings).
Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 13, 2015

Comment 2 by leonarddr on 2015-02-13 20:35
#4650 contains some accelerator changes, also the announce formatting changes option in document formatting currently doesn't have an accelerator.
Suggestions:

  • Play audio coordinates: P
  • Brightness: B
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 13, 2015

Comment 3 by jteh (in reply to comment 2) on 2015-02-13 21:12
Replying to leonarddr:

also the announce formatting changes option in document formatting currently doesn't have an accelerator.

I assume you mean "Announce formatting changes after the cursor (can cause a lag)"? I'm not sure there's really a need to have an accelerator for that one, since
I can't see it being toggled that often and it's the first option in the dialog anyway.

Suggestions:

  • Play audio coordinates: P
  • Brightness: B

Sounds good.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 13, 2015

Comment 4 by leonarddr on 2015-02-13 21:21
Added this in branch t4916 on http://bitbucket.org/leonardder/nvda.git. Also tested, so feel free to merge into next.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 13, 2015

Comment 5 by jteh on 2015-02-13 21:23
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 15, 2015

Comment 6 by bhavyashah on 2015-02-15 04:34
Hi,
As per Comment: 1, here are all keyboard accelerator related problems in the NVDA GUI:
Show exit options when exitting NVDA - Alt + w (current) should be revised to Alt + e (e for 'exit')
Output Device: (in Synthesizer dialog) - Alt + d (current) should be revised to Alt + o (o for 'output', output in my opinion is more prominent here than device)
Automatic dialect switching (if supported) - add Alt + d
Automatic language switching (if supported) - add Alt + l
Punctuation/Symbol Level - Alt + l (current) should be revised to Alt + s (s for 'symbol', since symbol here is more prominent than level, and in their respective keyboard accelerator conflicts, 'automatic language switching' is more used (in my experience) than 'use spelling functionality (if supported)')
Use spelling functionality if supported - may be taken under consideration for change, not compulsorily needed
I will list more keyboard accelerator problems in a subsequent ticket(s).

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 15, 2015

Comment 7 by bhavyashah on 2015-02-15 05:05
Continuation of keyboard accelerator related problems:
Use Caps Lock as an NVDA modifier key - add Alt + c
Use Numpad Insert as an NVDA modifier key - add Alt + n
Use extended Insert as an NVDA modifier key - add Alt + x
Speech interrupt for typed characters - add Alt + t
Speech interrupt for Enter key - Alt + e
Beep if typing lower case letters when Caps lock is on - add Alt + b
Simple review mode - add Alt + s
Automatically report all available candidates - revise Alt + c (current) to Alt + a (c should be avoided since another option uses it as well, words starting with 'a' are in number in this option, and quite prominent, such as automatically, all and available)
Quite some options in remaining NVDA settings dialogs lack keyboard accelerators, hope someone else may suggest appropriate keyboard accelerators for those.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 15, 2015

Comment 8 by jteh on 2015-02-15 07:21
Please avoid changing any existing accelerators unless you have to in order to allow for new accelerators and/or avoid duplication for important options. Regardless of whether you think a change makes more sense (which is subjective to some extent anyway), existing users may already be using it and we shouldn't detriment those users without a better reason than "it's nicer". Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 15, 2015

Comment 9 by bhavyashah on 2015-02-15 07:39
Ok, agreed.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 20, 2015

Comment 10 by James Teh <jamie@... on 2015-02-20 06:09
In [8b85f9c]:

Merge branch 't4916' into next

Incubates #4916.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 26, 2015

Comment 12 by James Teh <jamie@... on 2015-03-26 05:27
In [1ca13af]:

In NVDA's Mouse Settings dialog, keyboard shortcuts have been added for play audio coordinates when mouse moves and brightness controls audio coordinates volume.

Also capitalized those first letters as they weren't before, which was inconsistent with the other options in this window.
Fixes #4916.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 8, 2015

Comment 13 by leonarddr on 2015-07-08 10:58
Since this ticket contains accelerator suggestions for options which currently don't have an accelerator, here is a list of those options along with suggestions:

General settings:

  • Use NVDA on the Windows logon screen (requires administrator privileges): I
  • Use currently saved settings on the logon and other secure screens (requires administrator privileges): C
    Voice settings:
  • Automatic language switching (if supported): U
  • Automatic dialect switching (if supported): D
  • Trust voice's language when processing characters and symbols: T
  • Capital pitch change percentage: H
    Braille settings:
  • Cursor blink rate (ms): C
  • Message timeout (sec): M
  • Braille tethered to: T
    Keyboard Settings:
  • Use CapsLock as an NVDA modifier key: L
  • Use numpad Insert as an NVDA modifier key: N
  • Use extended Insert as an NVDA modifier key: X
  • Speech interrupt for typed characters: T
  • Speech interrupt for Enter key: E
  • Beep if typing lowercase letters when caps lock is on: B
    Review Cursor:
  • Simple review mode: S
    Object presentation:
  • Report background progress bars: R
    Browse mode:
  • Use screen layout (when supported): change to U in order to avoid duplicate accelerator
  • Automatic focus mode for focus changes: F
  • Automatic focus mode for caret movement: C
  • Audio indication of focus and browse modes: I
    Document Formatting:
  • Announce formatting changes after the cursor (can cause a lag: G (Despite it is the first option, I'd at one for consistency reasons).

@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

In NVDA's Mouse Settings dialog, keyboard shortcuts have been added f…
…or play audio coordinates when mouse moves and brightness controls audio coordinates volume.

Also capitalized those first letters as they weren't before, which was inconsistent with the other options in this window.
Fixes #4916.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment