New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse mode: provide braille feedback while pressing NVDA+space #5239

Closed
nvaccessAuto opened this Issue Jul 23, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@nvaccessAuto

nvaccessAuto commented Jul 23, 2015

Reported by surfer0627 on 2015-07-23 02:51
Expected: While pressing NVDA+space, NVDA provides braille feedback (focus mode / browse mode.

Now, in browse mode, while pressing NVDA+shift+space, NVDA provides speech and braille feedback (Single letter navigation on / off).

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 23, 2015

Comment 1 by jteh on 2015-07-23 02:55
One question to consider: should braille feedback be provided if "Audio indication of focus and browse modes" is enabled? In that case, the spoken message is suppressed, so arguably, the same should occur for braille, since a user using both speech and braille might find this message redundant in this case.

nvaccessAuto commented Jul 23, 2015

Comment 1 by jteh on 2015-07-23 02:55
One question to consider: should braille feedback be provided if "Audio indication of focus and browse modes" is enabled? In that case, the spoken message is suppressed, so arguably, the same should occur for braille, since a user using both speech and braille might find this message redundant in this case.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 23, 2015

Comment 2 by surfer0627 (in reply to comment 1) on 2015-07-23 03:19
Replying to jteh:

I agree the point.
NVDA provides braille feedback only when "Audio indication of focus and browse modes" is disabled.

nvaccessAuto commented Jul 23, 2015

Comment 2 by surfer0627 (in reply to comment 1) on 2015-07-23 03:19
Replying to jteh:

I agree the point.
NVDA provides braille feedback only when "Audio indication of focus and browse modes" is disabled.

dkager added a commit to dkager/nvda that referenced this issue Nov 21, 2015

When toggling between browse mode and focus mode, also show the new m…
…ode name in braille instead of only speaking it. Fixes nvaccess#5239.
@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Nov 21, 2015

Collaborator

Very trivial fix by the looks of it.

Collaborator

dkager commented Nov 21, 2015

Very trivial fix by the looks of it.

@jcsteh jcsteh self-assigned this Nov 23, 2015

@jcsteh jcsteh added this to the 2016.1 milestone Nov 23, 2015

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Nov 23, 2015

Contributor

Thanks!

Note to self: Good to merge.

Contributor

jcsteh commented Nov 23, 2015

Thanks!

Note to self: Good to merge.

jcsteh added a commit that referenced this issue Nov 25, 2015

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Nov 25, 2015

Incubated in 8ef4a4d.

dkager added a commit to dkager/nvda that referenced this issue Nov 28, 2015

When toggling between browse mode and focus mode, also show the new m…
…ode name in braille instead of only speaking it. Fixes nvaccess#5239.

@jcsteh jcsteh closed this in ad14be2 Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment